Implement procref instruction
#1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fumuran
force-pushed
the
andrew-implement-procref
branch
from
ca0f1c3
to
9905534
Compare
bobbinth
requested changes
Oct 20, 2023
There was a problem hiding this comment.
Looks good! Thank you! I left one small comment (with a bigger question) inline.
Other than that, there are two more things we should do:
- Update the code for formatted output to print
procrefinstruction correctly (see herehttps://github.com/0xPolygonMiden/miden-vm/blob/next/assembly/src/ast/nodes/format.rs#L94)). - Add an integration test to make sure we actually put correct MAST root onto the stack.
Fumuran
force-pushed
the
andrew-implement-procref
branch
from
ee2ef83
to
05834ca
Compare
bobbinth
requested changes
Oct 24, 2023
Fumuran
commented
Oct 25, 2023
bobbinth
reviewed
Oct 25, 2023
bobbinth
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
procrefinstruction.It is used as
procref.<procedure_name>and it puts a hash of a given procedure onto the stack using fourPushinstructions.TODO:
procrefinstruction.